Skip to content

fixed the problem with saving/loading light probes.#765

Merged
Nehon merged 1 commit into
jMonkeyEngine:masterfrom
JavaSaBr:fixed_saving_loading_light_probes
Nov 7, 2017
Merged

fixed the problem with saving/loading light probes.#765
Nehon merged 1 commit into
jMonkeyEngine:masterfrom
JavaSaBr:fixed_saving_loading_light_probes

Conversation

@JavaSaBr
Copy link
Copy Markdown
Contributor

@JavaSaBr JavaSaBr commented Nov 7, 2017

Fixed the problem with saving/loading light probes.

@JavaSaBr
Copy link
Copy Markdown
Contributor Author

JavaSaBr commented Nov 7, 2017

@Nehon could you look at this, please?

@pspeed42
Copy link
Copy Markdown
Contributor

pspeed42 commented Nov 7, 2017

Note: we see all of the commits as they come through. You don't have to mention us all the time unless it's been a while without comment.

@JavaSaBr
Copy link
Copy Markdown
Contributor Author

JavaSaBr commented Nov 7, 2017

ok :)

@Nehon
Copy link
Copy Markdown
Contributor

Nehon commented Nov 7, 2017

mhh ("position", this)... that was dumb...

Copy link
Copy Markdown
Contributor

@Nehon Nehon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good for me

@Nehon
Copy link
Copy Markdown
Contributor

Nehon commented Nov 7, 2017

Also @JavaSaBr you can just assign me in the "Reviewers" section on the top right I'll be notified.

I'll merge this PR once the build is green

@JavaSaBr
Copy link
Copy Markdown
Contributor Author

JavaSaBr commented Nov 7, 2017

@Nehon oh, ok :)

@Nehon Nehon merged commit 839ffdd into jMonkeyEngine:master Nov 7, 2017
@JavaSaBr JavaSaBr deleted the fixed_saving_loading_light_probes branch December 7, 2017 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants