Enable to display CJK characters for sdk v3.2 by hangingman · Pull Request #281 · jMonkeyEngine/sdk

hangingman · 2020-08-08T17:22:53Z

fix #73

Whats' this PR do ?

Fix 3.1-beta1-SNAPSHOT can't display chinese charset #73 issue, enable to display CJK characters for sdk v3.2

Problem

According to this StackOverflow post, DejaVu font doen't support CJK glyphs
- https://stackoverflow.com/questions/18065028/does-dejavu-has-support-for-cjk-chinese-japanese-korean-glyphs/18065154#18065154
However, jMonkey sdk, DarkMonkeyLookAndFeel.java forces swing window to use font as "DejaVu Sans Condensed-PLAIN-12".
This causes menu displays to be unreadable for CJK locale users ( and there are other locales not supported).

Solution

Main modification

Get a language coverage file for DejaVu fonts from https://github.com/dejavu-fonts/dejavu-fonts/blob/version_2_34/dejavu-fonts/langcover.txt
Parse that with a simple awk script, generate property file contains information about DejaVu fonts supporting the language and country code.
On DarkMonkeyLookAndFeel.java, apply DejaVu font if it supports glyphs for current user's locale and country

Gradle

Add a new task copyEngineLibs that copy dependency jar files under ./engine directory into lib directory.
- This task retrieve corelibs, optlibs, testdatalibs, examplelibs jar files name starting with jme3-, and renaming.
- Exceptionally, com.github.nifty-gui:nifty:1.4.2 jar will be copied.
Remove dependencies.resolve() lines
- This line requires gradle to get dependency jars from maven repository
- If there is no dependency jar files in local lib directory, this line causes error
- Current PR retrieve jar files with copyEngineLibs instead of dependencies.resolve()

// example
copyBaseLibs.inputs.files configurations.corelibs.resolve()
copyBaseLibs.outputs.dir "jme3-core-baselibs/release/modules/ext/"
copyBaseLibs.outputs.dir "jme3-core-libraries/release/modules/ext/"

misc
- I compiled sdk with Java8
- If project is compiled by Java11, the library javax.annotation.api will be required

MeFisto94

So the main change is okay, but the gradle changes need to be reverted. I know it didn't compile because of the removal of jogl, but it changes a lot of things that we don't want and also makes it even more platform dependant. I've marked the two changes we could keep for the build.gradle, but they aren't really necessary.

MeFisto94 · 2020-08-10T18:37:00Z

+     * DejaVu doesn't support CJK glyphs
+     * @return true if user locale is "ja" or "ko" or "zh"
+     */
+    private Boolean userLangIsCJK() {


How is this for glyphs from thailand or india, I guess they would have similar problems?

Maybe so.
If so, I started to think it's better to find the list of what language is supported or not.
I will research what language is curretly supported by DejaVu fonts 2.34.

I found list of supported language code.
https://github.com/dejavu-fonts/dejavu-fonts/blob/version_2_34/dejavu-fonts/langcover.txt

I have created a list with property file with using this langcover.txt.

MeFisto94 · 2020-08-10T18:42:01Z

+        // >zh-sg Chinese in Singapore 0% (2/6765) 0% (2/6765) 0% (2/6765)
+        // >zh-tw Chinese (traditional) (0/13063) (0/13063) (0/13063)
+        String lang = System.getProperty("user.language");
+        return lang.matches("ja|ko|zh");


Is something like startsWith required for Chinese or maybe ^zh-.*$ or something?

I don't think so. Because the language code and country code is different property.
For example my default java language code and country code setting are

-Duser.language=ja -Duser.country=jp

UI should follow user's property of user.language.

I changed my mind, there are some minor patterns (can't detect supported or not by only language code).
It looks good to detect with both language code and country code.

mn-cn Mongolian in China (0/130) (0/130) (0/130) mn-mn Mongolian in Mongolia 100% (70/70) 100% (70/70) 100% (70/70)

hangingman · 2020-08-12T14:58:31Z

@MeFisto94 Hi,
I updated this PR. Would you please review it again ?
If PR is OK, I will put together a commit.

MeFisto94

Sorry, looks like I forgot to submit my review :/
Regarding the files I am not sure what the best approach would be, though, e.g. instead of awk having a gradle task auto-generate the file so it does not need to be in the repo? or not have that because the source file langcover.txt would never change.
Talking of langcover, does it have any license issues we should be aware of?

MeFisto94 · 2020-08-13T12:27:00Z

-        url "http://jcenter.bintray.com/"
-    }
+    jcenter()
+    mavenCentral()


Why is there mavenCentral though?

Removed mavenCentral()

MeFisto94 · 2020-08-13T12:31:46Z

@@ -0,0 +1,18 @@
+#!/bin/bash


I am still not sure about the existence of this, gradle's buildSdk task should take care of that in a better (version- and platform independent manner).

I update build.gradle to copy jar files from engine directory, and removed shell script.

* Add nifty-gui as dependencies * Apply DejaVu font if user locale is not supported * https://stackoverflow.com/a/18065154/2565527 * Add lang.properties to check DejaVu supporting tha language or not * Copy dependency jme3 jar files with gradle

hangingman · 2020-08-24T14:51:59Z

@MeFisto94 Hi,

Regarding the files I am not sure what the best approach would be, though, e.g. instead of awk having a gradle task auto-generate the file so it does not need to be in the repo? or not have that because the source file langcover.txt would never change.
Talking of langcover, does it have any license issues we should be aware of?

I think langcover.txt may not be changed in the future, so removed.

I am still not sure about the existence of this, gradle's buildSdk task should take care of that in a better (version- and platform independent manner).

I added copyEngineLibs task in the build.gradle. This task copy dependency jar files. And described detailed description on issue top.

MeFisto94 · 2020-09-05T11:46:52Z

+    }
+}
+
+def copyEngineJarsToLib(file, extraJars=["nifty"]) {


I still don't gather why you try to copy the files from the engine folder, where the idea is to use gradles dependency resolution?

Also why do you depend on nifty-gui through jitpack while we get it transitively through

sdk/build.gradle

Line 99 in 36d11b6

corelibs dep("org.jmonkeyengine:jme3-niftygui", false, false)

?

@MeFisto94
Because, in my understanding, the buildSdk task need to have dependency jars but there are no process to download or copy these jar files. Probably since that reason, on my local environment after executing buildSdk will cause gradle error "Could not find org.jmonkeyengine:jme3-*".

I'm afraid current build script don't resolve dependency jars (jme3-.jar) correctly. build_engine.sh generates many jme3-.jar files, but it don't copy files into /lib directory or maven local repository.
So, I modified build.gradle script. Is there any misunderstanding for my side ?

That's definitely a misunderstanding, because CI works (https://travis-ci.org/github/jMonkeyEngine/sdk/jobs/724436054).
If that error was about a specific jme3-jogl, that's fixed in 56cdc94, essentially: Your engine folder needs to be on 3.3 (checkout or delete it and let the scripts work).

Due to

sdk/settings.gradle

Line 2 in 36d11b6

includeBuild './engine'

, engine dependencies should be there (unless jogl, which got deleted by the engine)

sdk/build.gradle

Line 167 in 36d11b6

task copyBaseLibs(dependsOn:configurations.corelibs) {

Is the part which is copying them into a netbeans module, from which it is then available.

So all in all, it should work. Sorry for being not clear enough about this in the beginning, so you had that extra work

hangingman · 2020-11-14T01:18:52Z

Close PR, and will reopen after fixed.

hangingman mentioned this pull request Aug 8, 2020

3.1-beta1-SNAPSHOT can't display chinese charset #73

Open

MeFisto94 requested changes Aug 10, 2020

View reviewed changes

hangingman marked this pull request as ready for review August 12, 2020 14:55

MeFisto94 reviewed Aug 17, 2020

View reviewed changes

Hiroyuki-Nagata added 2 commits August 24, 2020 23:21

add .gitignore entry

cb31993

MeFisto94 reviewed Sep 5, 2020

View reviewed changes

hangingman closed this Nov 14, 2020

Conversation

hangingman commented Aug 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Whats' this PR do ?

Problem

Solution

Main modification

Gradle

Uh oh!

MeFisto94 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hangingman Aug 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hangingman commented Aug 12, 2020

Uh oh!

MeFisto94 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hangingman commented Aug 24, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hangingman commented Nov 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hangingman commented Aug 8, 2020 •

edited

Loading

hangingman Aug 11, 2020 •

edited

Loading