chore: gofmt the 6 pre-existing unformatted files on refactor/total#121
Merged
Conversation
These six files accumulated gofmt drift across the prior squash-merges onto refactor/total (trailing blank lines, struct/comment column re-alignment, one import-group reorder). They predate and are unrelated to any in-flight feature branch, but `make lint` (gofmt -l . | (! read)) fails repo-wide on their account — blocking CI for every branch cut from refactor/total. Pure `gofmt -w`; zero behavior change (build, vet, full unit suite green). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 0.19.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make lintrunsgofmt -l . | tee /dev/stderr | (! read)— it fails repo-wide if any Go file is unformatted. Six files have accumulated gofmt drift across the prior squash-merges ontorefactor/totaland are dirty on the base branch itself:api/v1alpha1/cloudflareoperator_types_test.go— trailing blank lineinternal/reconcile/owner.go— trailing blank lineinternal/controller/tunnel/setup_indexers_test.go— comment-column re-alignmentinternal/controller/zone/zone_controller_test.go— struct-literal field alignmentinternal/controller/zone/zoneconfig_controller.go— one import moved into its correct grouptest/envtest/tunnel_annotation_inheritance_test.go— whitespaceThese predate and are unrelated to any in-flight feature branch, but they make
make lintfail for every branch cut fromrefactor/total(incl. the open P4 and P5 PRs) for a base-branch reason. Puregofmt -w; zero behavior change.Test Plan
gofmt -l .now reports nothing (whole repo clean)go build ./...clean ·go vet ./...cleango test -count=1 ./...— all packages pass (no behavior change)🤖 Generated with Claude Code