Update CMake test config #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks! I know I was experimenting with both before (it seems libappanvil uses the newer macro). I can't remember why I settled on gtest_add_tests. I'll merge your change soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
gtest_add_testsmacro is very old and breaks when building on newer versions of CMake (in my case cmake 3.31.4-1 on ArchLinux).Switching to
gtest_discover_testsand omitting theSOURCESoption works, but whichever is causing the issue is unclear.By the way, doing this seems to automatically ignore the unused tests, which is a plus in my book.
I'm pasting the results from running
make testto prove that no regression is introduced.Before:
After: