Fix LoadTypes error handling#2549
Open
jaltavilla wants to merge 1 commit into
Open
Conversation
…ng manual loop with ForEachRow to fix this.
Owner
|
Can we just add the error check rather than changing the loop type? |
Author
|
If that's how you would prefer it to be fixed, I can make that change. It seems like using the helper that was created to remove the need for manual looping is safer. It would have prevented this bug as well as prevents future changes from introducing similar ones. Is there a downside to it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LoadTypes was missing a rows.Err() check at the end. Fixed by replacing manual loop with ForEachRow.
This fixes one of the issues in #2544