Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @jackdewinter - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Assert statement left in production code. (link)
Here's what I looked at during the review
- 🔴 General issues: 1 blocking issue
- 🟢 Security: all looks good
- 🟡 Testing: 3 issues found
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| original_line=original_line, | ||
| alternate_list_leading_space=alternate_leading_space, | ||
| ) | ||
| # assert False |
There was a problem hiding this comment.
issue (bug_risk): Assert statement left in production code.
It appears an assert False statement has been left in the code, likely for debugging purposes. This will raise an AssertionError every time this code path is executed, which could disrupt normal operation. Please remove or comment it out if it's no longer needed.
| TBD | ||
| """ | ||
|
|
||
| # Arrange |
There was a problem hiding this comment.
issue (testing): Removal of test cases reduces coverage for block quotes and lists.
The deletion of these test cases seems to remove coverage for specific markdown scenarios involving block quotes and lists. Please ensure that the removal is intentional and consider adding alternative tests if these scenarios are still relevant.
| fix_expected_file_contents="""item 1 | ||
| """, | ||
| ), | ||
| pluginRuleTest( |
There was a problem hiding this comment.
suggestion (testing): New test case for issue-1015 does not cover all edge cases.
The new test case 'issue-1015-positive' checks for hard tabs but does not seem to cover variations such as tabs in different contexts or mixed with spaces. Consider adding more comprehensive test scenarios to ensure robustness.
| fix_expected_file_contents="""item 1 | ||
| """, | ||
| ), | ||
| pluginRuleTest( |
There was a problem hiding this comment.
suggestion (testing): Consider adding a positive test case without disabling MD010.
The 'issue-1015-negative' test case disables MD010 to test for MD047. Adding a positive test case that does not disable MD010 could help ensure that MD010 works as expected in conjunction with other rules.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1050 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 189 189
Lines 19197 19207 +10
Branches 2393 2394 +1
=========================================
+ Hits 19197 19207 +10 ☔ View full report in Codecov by Sentry. |
1 participant
#1015