Skip to content

Use consistent ordering (W0013 then W0014) in test fixture and fix typo#121

Merged
jackdomleo7 merged 1 commit intojackdomleo7:masterfrom
tannerdolby:120-cleanup
Oct 10, 2021
Merged

Use consistent ordering (W0013 then W0014) in test fixture and fix typo#121
jackdomleo7 merged 1 commit intojackdomleo7:masterfrom
tannerdolby:120-cleanup

Conversation

@tannerdolby
Copy link
Copy Markdown
Contributor

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Cleans up #120

  • The ordering of HTML for W0013 and W0014 was backwards in the test fixture test/index.html
  • Update the text content for the <h2> representing the "links to files" section as it had the same content as other warning before.

Link(s)

Screenshot(s)

Checklist:

  • I have thoroughly read the CONTRIBUTING guidelines.
  • I understand my pull request will be thoroughly reviewed at high detail.
  • I understand the work in my pull request will only be available in the next version release of Checka11y.css and not in the current version release.
  • I confirm the work in this pull request is valid according to my findings and is not something for anything personal.
  • I have updated the README and/or features.md where and if applicable (still put an x if you have considered this but thought there was nothing to add or modify).
  • I have added myself to the contributors section in package.json (still put an x if you have considered this but decided not to add yourself).
  • I have checked I have not committed any accidental files.
  • I have tested all the main modern browsers (I.e. Chrome, Firefox, Edge, Safari - please leave this unchecked if there were any browsers listed you could not test and list them in the help section with details why you couldn't test that browser)
  • I have run the automated tests and added new ones to cover new code.
  • All new and existing a11y checks still work correctly (compare your local test/index.html to the test/index.html in the master branch).

@jackdomleo7 jackdomleo7 added Hacktoberfest Hacktoberfest eligible project enhancement Enhancement to improving the overall project labels Oct 10, 2021
@jackdomleo7 jackdomleo7 merged commit 5f5184e into jackdomleo7:master Oct 10, 2021
@tannerdolby tannerdolby deleted the 120-cleanup branch October 10, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Hacktoberfest Hacktoberfest eligible project enhancement Enhancement to improving the overall project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants