-
Notifications
You must be signed in to change notification settings - Fork 12
Pass analyzers as required parameter to source-analyze #687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: jackfirth <8175575+jackfirth@users.noreply.github.com>
Co-authored-by: jackfirth <8175575+jackfirth@users.noreply.github.com>
jackfirth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
private/analysis.rkt
Outdated
| [source-analyze (->* (source?) | ||
| (#:lines range-set? | ||
| #:analyzers (listof expansion-analyzer?)) | ||
| source-code-analysis?)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make it a required parameter and update the callers to pass in the list instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in feb8469. The #:analyzers parameter is now required, and all callers in main.rkt explicitly pass the list of analyzers.
Co-authored-by: jackfirth <8175575+jackfirth@users.noreply.github.com>
The
source-analyzefunction hardcoded three expansion analyzers. This change makes the analyzer list a required parameter to enable future work where analyzers are determined by the refactoring suite.Changes:
#:analyzersrequired parameter tosource-analyzemain.rktto explicitly pass the analyzer list (identifier-usage-analyzer, ignored-result-values-analyzer, variable-mutability-analyzer)main.rktsequence-appendof individual calls totransducewithappend-mappingover the parameterUsage:
All existing callers have been updated to explicitly pass the analyzer list.
source-analyze#682Original prompt
source-analyze#682💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.