Support importing analyzers directly in test require: statements #703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jackfirth <8175575+jackfirth@users.noreply.github.com>
…-recommendations Co-authored-by: jackfirth <8175575+jackfirth@users.noreply.github.com>
Co-authored-by: jackfirth <8175575+jackfirth@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor tests to support importing specific analyzers
Support importing analyzers directly in test require: statements
Nov 2, 2025
jackfirth
requested changes
Nov 2, 2025
test/private/rackunit.rkt
Outdated
Comment on lines
92
to
93
| ;; Additional analyzers that should be included when running analysis tests | ||
| (define current-analyzers-under-test (make-parameter (set))) |
Owner
There was a problem hiding this comment.
This is unnecessary, just add analyzers to the suite directly. Add an #:analyzers argument to the refactoring-suite constructor that accepts a sequence of analyzers to include alongside the analyzers gathered from the suite's rules and subsuites.
Contributor
Author
There was a problem hiding this comment.
Done in commit 1077e55. Added #:analyzers parameter to refactoring-suite constructor and updated add-suite-under-test! to add analyzers directly to the suite instead of tracking them separately.
…andling Instead of tracking analyzers separately in test infrastructure, analyzers are now added directly to the suite via the #:analyzers parameter. This simplifies the implementation and makes the suite's analyzer collection more explicit. - Updated refactoring-suite contract to accept #:analyzers parameter - Modified refactoring-suite function to combine rule analyzers with explicitly provided analyzers - Updated add-suite-under-test! to build suites with analyzers included - Simplified check-suite-analysis to use suite's analyzers directly - Removed separate current-analyzers-under-test parameter Co-authored-by: jackfirth <8175575+jackfirth@users.noreply.github.com>
Pull Request Test Coverage Report for Build #127Details
💛 - Coveralls |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Resyntax analyzed 5 files in this pull request and found no issues.
jackfirth
requested changes
Nov 2, 2025
test/private/rackunit.rkt
Outdated
Comment on lines
272
to
277
| (λ () | ||
| (define full-source (source->string program-src)) | ||
| (if (string-prefix? full-source "#lang racket") | ||
| (source-code-analysis-added-syntax-properties | ||
| (source-analyze program-src #:analyzers all-analyzers)) | ||
| (syntax-property-bundle))))) |
Owner
There was a problem hiding this comment.
I think the right implementation here should just pass in the suite under test using (resyntax-analyze-for-properties-only program-src #:suite suite).
Contributor
Author
There was a problem hiding this comment.
Done in commit 450875e. Simplified by delegating to reysntax-analyze-for-properties-only instead of reimplementing the analysis logic.
…s-only Instead of reimplementing the analysis logic with error handling and #lang racket checks, delegate to the existing reysntax-analyze-for- properties-only function which already handles all these cases. - Replaced custom analysis logic with call to reysntax-analyze-for-properties-only - Removed unnecessary resyntax/private/analysis import - Simplified implementation while maintaining same functionality Co-authored-by: jackfirth <8175575+jackfirth@users.noreply.github.com>
jackfirth
approved these changes
Nov 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
require:statement currently worksrequire:statement to accept analyzers (already handles it via runtime check)Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.