Fix metric parsing in localized versions#51
Open
tekkamanendless wants to merge 1 commit intojackpal:masterfrom
Open
Fix metric parsing in localized versions#51tekkamanendless wants to merge 1 commit intojackpal:masterfrom
tekkamanendless wants to merge 1 commit intojackpal:masterfrom
Conversation
In English, `route` will print `On-link` for an on-link route. Conveniently, `On-link` is a single token with no spaces. However, in Spanish, the phrase is `En vínculo`, which has a space in it. This updates the field logic when parsing routes to combine any consecutive tokens that start with a letter to work around this.
stan-threatmate
approved these changes
Apr 1, 2026
This was referenced Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In English,
routewill printOn-linkfor an on-link route. Conveniently,On-linkis a single token with no spaces. However, in Spanish, the phrase isEn vínculo, which has a space in it.This updates the field logic when parsing routes to combine any consecutive tokens that start with a letter to work around this.