fix(code-quality): Fix for Explicit returns mixed with implicit (fall through) returns#516
Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…urns may indicate an error, as implicit returns always return None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General fix: ensure
redirect_urlhas an explicit return for all code paths, and avoidreturn Noneafterabort()in view functions. In Flask handlers, either return a valid response object/string/tuple or raise viaabort().Best fix in this file: in
app/app.py, insideredirect_url(around lines 167–201), replace theabort(...); return Noneblock with a directreturn page_not_found(...)using the existing error handler function. This guarantees an explicit Flask response object on that branch and removes the problematicNonereturn path. Also add a final defensive return after thematchto ensure an explicit response in all analyzer-visible paths.Suggested fixes powered by Copilot Autofix. Review carefully before merging.