fix(code-quality): Fix for Explicit returns mixed with implicit (fall through) returns#517
Merged
Merged
Conversation
…) returns Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
91b5909 to
216837e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix this, make
input_url()total: every control-flow path must explicitly return a response or raise viaabort.Best minimal fix without changing behavior: add a final fallback return after the
matchininput_url()that returns the existing 500 handler response. This prevents implicitNonereturn if any path in the"POST"branch ever falls through.Edit in
app/app.py, insideinput_url():return Noneafterabort(...)incase _with a concrete response return (or remove it), andreturn internal_server_error(HTTPStatus.INTERNAL_SERVER_ERROR)at function end so no implicit return is possible.No new imports or dependencies are needed.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.