feat(twitter): surface tweet id on bookmarks/likes/tweets listings#1301
Merged
feat(twitter): surface tweet id on bookmarks/likes/tweets listings#1301
Conversation
3 tasks
Round 6 — silent-drop audit follow-up. Sibling twitter listings have been inconsistent about the canonical tweet `id` (rest_id): - timeline ✓ exposes id - search ✓ exposes id - list-tweets ✓ exposes id - notifications ✓ exposes id - bookmarks ✗ extracts but drops it from columns - likes ✗ extracts but drops it from columns - tweets ✗ extracts but drops it from columns The `id` is already in the row object — only the `columns` projection was missing. With the listing↔detail id-pairing CI gate from #1297 now on main, surfacing `id` makes round-trip into `twitter thread <id>` / `twitter delete <id>` / `twitter like <id>` work from the table view too (previously only via `-f json`). Other field-presentation drift (`name`, `created_at`, `retweets`) aligned with sibling adapters where those values are already emitted. Tests: tweets.test.js asserts `toEqual` on the columns array — updated that assertion. Other twitter tests use `toMatchObject` and pass unchanged. 81/81 in `clis/twitter/`.
jackwener
force-pushed
the
feat/twitter-listing-id-consistency
branch
from
93670e4 to
4db731b
Compare
jackwener
added a commit
that referenced
this pull request
May 4, 2026
…(sweep) (#1305) * feat(youtube/xiaohongshu/xiaoe): surface dropped ids/url on listings (sweep) Round 8 same silent-column-drop class as #1300/#1301/#1302 — row already emits the id/url field but `columns` array forgot to project it, so table view drops it and agent loses the chain into detail commands. - youtube/feed: rename row.videoId → video_id (snake_case convention), add to columns. youtube/video accepts both URL and id, so url-based round-trip already worked, but exposing the canonical id removes the url-parse step for chained calls. - xiaohongshu/feed: pipeline map already extracts `id` from the homefeed payload, columns now lists it. - xiaoe/catalog: pipeline map already projects `url`, columns now lists it. xiaoe/detail takes a positional url, so this completes the round-trip explicitly. Also fixes one camelCase column violation on youtube/feed (videoId vs the project's snake_case convention as in twitter `is_retweet`/`created_at`, douban `subject_id`/`photo_id`, hupu `thread_title`). CI gate `check:listing-id-pairing` ✓ (34 sites, 77 listings, 10 exempt). typecheck clean. 114 tests pass for youtube + xiaohongshu. * fix(youtube): keep feed continuation ids after rename
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Round 6 silent-drop audit follow-up. The canonical tweet
id(rest_id) is inconsistent across twitter listings:idexposed in columns?timelinesearchlist-tweetsnotificationsbookmarkslikestweetsEach row object already contained
id— only thecolumnsprojection was missing, so JSON output (-f json) already had it but the table view didn't. Same bug class as PRs #1284 / #1285 / #1288 / #1289 / #1291 / #1293 / #1300.With the listing↔detail id-pairing CI gate from #1297 now active on main, surfacing
idlets the table view round-trip intotwitter thread <id>/twitter like <id>/twitter delete <id>etc., not just-f json.Changes per file
bookmarks:columns←[id, author, text, likes, retweets, bookmarks, created_at, url]likes:columns←[id, author, name, text, likes, retweets, created_at, url, has_media, media_urls]tweets:columns←[id, author, created_at, is_retweet, text, likes, retweets, replies, views, url, has_media, media_urls]While at it, aligned
created_at/retweets/nameprojections with sibling adapters where those values were already emitted but dropped from columns.Test plan
npx vitest run clis/twitter/— 81/81 passtweets.test.jshad a stricttoEqualon the columns array — updated it to match new shapenpm run check:listing-id-pairing— passes (no longer relies on URL fallback for these listings)npx tsx src/build-manifest.ts— 660 entries, columns delta onlyAudit context
This PR is one fix from a wider silent-drop audit run earlier today (15 listings across 8 sites). Other findings (1688/search dropping
offer_id, hupu/mentions droppingtid/pid, douban/photos droppingphoto_id, etc.) will follow as separate focused PRs after this one lands.