refactor(browser): replace workspace with explicit sessions#1461
Merged
Conversation
5428321 to
8d058af
Compare
8d058af to
f613250
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--workspacemodel with required--session <name>onopencli browser *--domain,--path-prefix,--allow-navigate-bound) and remove browser namespace--keep-tabsession,surface,kind, with browser result/session docs updatedbrowserSession.reuse: 'site'behavior unchanged; only the browser user surface changes hereVerification
npx tsc --noEmitnpm test -- --run clis/notebooklm/*.test.js src/cli.test.ts src/browser/page.test.ts src/browser/daemon-client.test.ts src/browser/network-cache.test.ts src/doctor.test.ts src/execution.test.ts src/observation/manager.test.ts src/observation/artifact.test.tsnpx vitest run --project extension extension/src/background.test.tsnpm run buildnpm run typecheck && npm run buildinextension/npm run docs:buildnpm run check:typed-error-lintnpm run check:silent-column-dropgit diff --checkNotes
Breaking by design: no backward compatibility for
--workspace/bound:browser surface. Adapter site-continuity rename tositeSession: 'persistent'is a follow-up PR.