fix: resolve alias target correctly in validate command#949
Merged
Conversation
The alias resolution logic checked `!registry.has(target)` before calling `registry.get(target)`, which always returned undefined. Moreover, aliases registered as `site/alias` keys meant `registry.has` returned true, skipping the block entirely. The canonical name was never resolved, so `validate site/alias` silently checked 0 commands. Simplify to always resolve via `registry.get(target)` which handles both canonical keys and alias keys correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate site/aliassilently checking 0 commands instead of resolving to the canonical command!registry.hasthenregistry.geton same key), and aliases registered assite/aliaskeys bypassed the block entirelyregistry.get(target)which handles both canonical and alias keysContext
Found by @codex-mini0 during release review. The bug was introduced in #943.
Test plan
opencli validate hupu/mentionshould now correctly resolve and validate the canonical commandopencli validate hupu/hot(canonical name) should continue to workopencli validate hupu(site-level) should continue to work