fix: warn when user .ts adapters are silently skipped#951
Merged
Conversation
Users who created custom .ts adapters in ~/.opencli/clis/ will see their commands silently disappear after upgrading to the JS-only version. Add an explicit warning so they know to convert to .js.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.tsadapter files are found in user's~/.opencli/clis/directory.tsadapters will see their commands silently disappear after upgrading to the JS-only versionContext
Found by @codex-mini0 during release review. The
.tscleanup in #948 only handles official adapters with.jscounterparts. User-created.tsadapters have no counterpart and were silently ignored with no warning.Test plan
.tsadapter in~/.opencli/clis/demo/hello.ts, runopencli list— should see warning in stderr.jsadapters should continue to load normally