fix: clean up stale .yaml adapter files from older versions (#953)#986
Merged
fix: clean up stale .yaml adapter files from older versions (#953)#986
Conversation
Users upgrading from v1.6.x retain .yaml adapter files in ~/.opencli/clis/ that trigger "Ignoring YAML adapter" warnings on every run. The hash-based sync only tracks .js files, so these legacy .yaml files are never cleaned up. Add a cleanup step (3b) that removes .yaml/.yml files from user adapter directories when the corresponding site exists in the official package (i.e., the site has been migrated to .js).
This was referenced Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #953 — users upgrading from v1.6.x see dozens of "Ignoring YAML adapter" warnings on every run.
.yamlfiles and copied them to~/.opencli/clis/.js, but the hash-based sync only tracks.jsfiles.yamlfiles in~/.opencli/clis/were never cleaned up, causing persistent warningsAdds a cleanup step (3b) in
fetch-adapters.jsthat removes.yaml/.ymlfiles from user adapter directories when the corresponding site exists in the official package. Same pattern as the existing stale.tscleanup (step 3).Test plan
.yamlfiles in~/.opencli/clis/hackernews/, runOPENCLI_FETCH=1 node scripts/fetch-adapters.js, verify they are removed