Fix automation window not closing on command failure#992
Merged
Conversation
The error path in executeCommand did not call page.closeWindow(), leaving the automation window open until the extension's idle timer fires. On Windows, MV3 service worker suspension makes this timer unreliable, causing windows to linger indefinitely. Now closeWindow is called after diagnostic collection but before rethrowing, ensuring the window is closed on both success and failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
page.closeWindow()to the error path inexecuteCommand(), after diagnostic collection but before rethrowingRoot cause
The automation window lifecycle was only managed on the success path (
execution.ts:226). On failure, the window was orphaned and depended onsetTimeoutin the extension's service worker — which Chrome can suspend before the callback fires, especially on Windows.Changes
src/execution.ts: AddcloseWindowcall in catch block (after diagnostic, before throw)src/execution.test.ts: Add regression test verifyingcloseWindowis called on browser command failureTest plan
calls closeWindow on browser command failurepasses