perf: smart page settle via DOM stability detection#271
Merged
Conversation
Replace fixed settleMs sleep in goto() with MutationObserver-based DOM stability detection. The page is considered settled when no DOM mutations occur for quietMs (default 500ms), with settleMs as a hard timeout cap. Changes: - Add waitForDomStableJs() shared helper to dom-helpers.ts - Update Page.goto() and CDPPage.goto() to use smart settle - No IPage interface changes (implementation detail only) Key improvements over naive approach: - Timer starts AFTER MutationObserver.observe() to avoid race condition - Falls back to sleep(maxMs) if document.body is not available - Monitors attributes in addition to childList/subtree - quietMs defaults to 500ms (conservative) for async request buffering
jackwener
force-pushed
the
perf/smart-page-settle
branch
from
59fc888 to
5f3b31c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
settleMssleep ingoto()with a smartwaitForDomStable()method.MutationObserverto detect when the page stops changing (no mutations for 300ms, capped at 3000ms).Page(HTTP/WS daemon) andCDPPage(direct CDP connection).This significantly speeds up command execution for fast SPA pages (like Twitter, which render in 200ms) by avoiding unnecessary waiting, while still correctly waiting for slower pages to fully render.