fix: resolve 6 critical bugs from deep code review (round 2)#337
Merged
fix: resolve 6 critical bugs from deep code review (round 2)#337
Conversation
1. execution.ts: Guard lazy-loaded func commands against null page — if a lazy module incorrectly requires browser context, throw a clear error instead of a cryptic TypeError on page.goto(). 2. daemon.ts: Fix readBody race condition — add aborted flag to prevent req.destroy() from triggering both reject (via error) and resolve (via end event) on the same Promise, which could process truncated data. 3. browser/cdp.ts: Prevent CDPBridge.connect() reentry — throw if already connected instead of silently leaking the previous WebSocket and its message handlers. 4. interceptor.ts: Store intercept pattern in a separate global variable so subsequent installInterceptor calls with different patterns update the match condition without being blocked by the patchGuard. 5. record.ts: Always call cleanupEnter() after Promise.race — previously only called in the timeout path, leaving readline open when user pressed Enter, potentially blocking process exit. Also removed unused enterRace. 6. generate.ts: Fix undefined entering String.includes() — when c.name is undefined, toLowerCase() returns undefined which gets coerced to the string "undefined" by includes(), causing false positive matches. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
Author
|
Reviewed and merged. The 6 critical fixes are coherent, regression risk is low, and local validation passed ( |
jackwener
added a commit
that referenced
this pull request
Mar 24, 2026
The C2 fix in PR #337 added a null-page guard after lazy-loading TS modules, but it threw unconditionally — breaking all browser:false commands (bloomberg, apple-podcasts, google, yollomi, etc.) that use func() with a null page. Guard now checks updated.browser !== false. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
4 tasks
jackwener
added a commit
that referenced
this pull request
Mar 24, 2026
The C2 fix in PR #337 added a null-page guard after lazy-loading TS modules, but it threw unconditionally — breaking all browser:false commands (bloomberg, apple-podcasts, google, yollomi, etc.) that use func() with a null page. Guard now checks updated.browser !== false. Also fixes apple-podcasts top E2E flake: when the command times out on CI, stderr is empty and the guard didn't catch it. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
4 tasks
jackwener
added a commit
that referenced
this pull request
Mar 24, 2026
…#347) The C2 fix in PR #337 added a null-page guard after lazy-loading TS modules, but it threw unconditionally — breaking all browser:false commands (bloomberg, apple-podcasts, google, yollomi, etc.) that use func() with a null page. Guard now checks updated.browser !== false. Also fixes apple-podcasts top E2E flake: when the command times out on CI, stderr is empty and the guard didn't catch it. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the remaining 6 Critical issues from the deep code review (round 1 fixed security issues in PR #335).
CommandExecutionErrorinstead of crypticTypeErrorwhen a lazy module incorrectly requires browser contextreadBodyrace condition — addabortedflag to preventreq.destroy()from triggering both reject and resolve on the same Promise (truncated data processing)CDPBridge.connect()reentry — throw if already connected instead of silently leaking the previous WebSocketinstallInterceptorwith a new pattern updates the match condition instead of being blocked by patchGuardcleanupEnter()afterPromise.race— previously only called in timeout path, leaving readline open on Enter exit. Removed deadenterRacevariableundefinedenteringString.includes()—c.name?.toLowerCase()returnsundefinedwhich gets coerced to string"undefined", causing false positive candidate matchesTest plan
🤖 Generated with Claude Code