fix(bilibili): distinguish login-gated subtitles from empty results#645
Merged
jackwener merged 2 commits intojackwener:mainfrom Mar 31, 2026
Merged
fix(bilibili): distinguish login-gated subtitles from empty results#645jackwener merged 2 commits intojackwener:mainfrom
jackwener merged 2 commits intojackwener:mainfrom
Conversation
…oThrow Awaiting the same rejected promise twice is unreliable. Combine the AuthRequiredError type check and message regex into one toSatisfy call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix
bilibili subtitleso login-gated subtitle responses are reported as auth-required instead of misleading empty results.Related issue:
Type of Change
Checklist
Documentation
(if adding/modifying an adapter)
docs/adapters/(if new adapter)docs/adapters/index.mdtable (if new adapter)Updated sidebar in
docs/.vitepress/config.mts(if new adapter)README.md/README.zh-CN.mdwhen command discoverability changedpositional args for the command's primary subject unless a named flag is clearly better\n- [x] Normalized expected adapter failures to
CliErrorsubclasses instead ofraw
Error\n\n## Screenshots / Output\n-npm test\n-npx vitest run --project adapter src/clis/bilibili/subtitle.test.ts src/clis/bilibili/comments.test.ts src/clis/ bilibili/dynamic.test.ts\n-npm run typecheck