Conversation
jackwener
changed the title
…se tab ID - Extract shared isTransientBrowserError() into browser/errors.ts, replacing duplicated string-matching lists in daemon-client.ts and pipeline/executor.ts - Cache compiled vm.Script objects in template.ts with LRU eviction (max 256), avoiding per-invocation VM context creation in pipeline loops - Add getActiveTabId() to IPage interface and Page class for tab state inspection
… CDPPage Both Page (daemon-backed) and CDPPage (direct CDP) had ~200 lines of identical DOM helper implementations (click, type, scroll, wait, snapshot, interceptor, etc). Extract shared logic into abstract BasePage class. Subclasses now only implement transport-specific methods.
…rences The file browser/mcp.ts contained BrowserBridge (daemon session manager), not MCP functionality. Renamed to bridge.ts for clarity. Also removed all stale "Playwright MCP" references from comments and variable names across the codebase — Playwright was removed long ago.
jackwener
force-pushed
the
refactor/src-cleanup
branch
from
dc9c798 to
fdaaea3
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isTransientBrowserError()intobrowser/errors.ts— replaces duplicated string-matching lists indaemon-client.tsandpipeline/executor.ts. Single source of truth for transient error patterns.vm.Scriptobjects inpipeline/template.tswith LRU eviction (max 256 entries) — avoids per-invocation VM context creation in pipeline loops, significant speedup for repeated expressions.getActiveTabId()toIPageinterface andPageclass — exposes previously hidden tab state for debugging and validation.Test plan
npm run typecheckpassesnpx vitest run src/pipeline/ src/browser/page.test.ts— 96 tests passnpx vitest run src/browser.test.ts— 17 tests pass