fix: update BrowserBridge test broken by PR #712#714
Merged
Conversation
…sDaemonRunning PR #712 refactored _ensureDaemon to use a single fetchDaemonStatus() call instead of separate isDaemonRunning(). The test was still mocking the old function, causing it to fall through to the spawn-daemon path and throw the wrong error message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_ensureDaemonto use a singlefetchDaemonStatus()call instead of separateisDaemonRunning()+isExtensionConnected()fails fast when daemon is running but extension is disconnectedwas still mocking the oldisDaemonRunning, causingfetchDaemonStatus()to returnnull(no daemon) and fall through to the spawn-daemon pathfetchDaemonStatusto return{ extensionConnected: false }so the test correctly exercises the "daemon running, extension missing" pathTest plan
npx vitest run --project unit src/browser.test.ts— all 17 tests passnpx vitest run --project unit— all 483 tests pass (0 failures)