fix(36kr): replace waitForCapture with DOM polling for search/hot#779
Merged
jackwener merged 2 commits intojackwener:mainfrom Apr 4, 2026
Merged
fix(36kr): replace waitForCapture with DOM polling for search/hot#779jackwener merged 2 commits intojackwener:mainfrom
jackwener merged 2 commits intojackwener:mainfrom
Conversation
waitForCapture(6) always times out on 36kr because the API intercept never captures a matching request. However, the DOM is already fully rendered with search/hot results by the time the timeout fires. Replace the 6-second intercept wait with a DOM polling loop that checks for article links (a[href*="/p/"]) every 300ms, returning immediately once content is available (typically ~1s vs 6s timeout + error). Tested on opencli 1.6.2 with both CDP and Browser Bridge modes.
- Rebase onto main after clis/ move (PR jackwener#782) - Remove installInterceptor calls (no longer used after waitForCapture removal) - Change strategy from INTERCEPT to PUBLIC (browser: true) to match actual behavior - Improve polling loop readability
jackwener
force-pushed
the
fix/36kr-intercept-timeout
branch
from
fa1c04c to
6825c3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
36kr searchand36kr hotalways fail withNo network capture within 6sbecausewaitForCapture(6)never intercepts a matching API requesta[href*="/p/"]every 300ms, return immediately once content is availableBefore
After
Test plan
opencli 36kr search "AI" --limit 3 -f jsonreturns results in ~1.3sopencli 36kr hot --limit 3 -f jsonreturns results in ~1.8s