fix: review follow-ups for monorepo adapter separation#783
Merged
Conversation
…version check - Clarify first-run log message: "copying adapters (one-time setup)" - Add comment explaining why scriptPath uses two levels of ../ - OPENCLI_FETCH=1 now bypasses version-skip to allow forced refresh
check-doc-coverage.sh still referenced src/clis/ after PR #782 moved adapters to root clis/. This caused CI to fail with "0/1 documented".
The symlink at ~/.opencli/node_modules/@jackwener/opencli pointed to dist/ instead of the package root in prod mode, breaking user TS CLIs that import from '@jackwener/opencli/registry'. The first-run scriptPath also resolved incorrectly in dev mode. Extract findPackageRoot() that walks up to find package.json, fixing both paths for dev (src/) and prod (dist/src/) layouts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up fixes from code review of #782:
../in scriptPath (correct in prod, dev has catch fallback)OPENCLI_FETCH=1now bypasses version-skip check to allow forced refresh of adapter filesTest plan