fix(twitter): relax reply composer textarea timeout to 15s#862
Merged
fix(twitter): relax reply composer textarea timeout to 15s#862
Conversation
The compose page needs to load Draft.js editor which is heavier than primaryColumn. 8s is too tight for slow networks and will cause flaky failures. 15s aligns with the file input timeout (20s) in magnitude.
jackwener
added a commit
that referenced
this pull request
Apr 7, 2026
…ipeline 1. Rebase on main picks up #860/#862 (all replies use dedicated composer), so dry-run no longer regresses the text-reply fix. 2. Switch incident mode metric from pass_count (higher) to regression_count (lower). eval-cli.ts now outputs REGRESSIONS=N alongside SCORE=X/Y. fix.ts incident mode greps for REGRESSIONS= so infra/precondition failures don't pollute the metric. 3. Add pre-flight check in incident mode: detects infra/precondition failures and bails early with a clear message instead of entering the engine loop. 4. Pass prompt via stdin (not shell-escaped string) in incident mode modify callback, matching the convention from main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tweetTextarea_0wait timeout from 8s to 15sFollow-up to #860 (merged). Review finding from #855.
Test plan
npx vitest run clis/twitter/reply.test.ts— 7 passed