fix: Twitter API error (HTTP 404) #39#40
Closed
stoneidolon wants to merge 1 commit intojackwener:mainfrom
Closed
Conversation
When get_ondemand_file_url() fails to extract the ondemand file URL from the homepage (due to page structure changes or access restrictions), it returns None. Previously, this None was passed directly to the HTTP request, causing a confusing 'NoneType' object has no attribute 'split' error. Now we explicitly check for None and raise a clear error message: "Failed to extract ondemand file URL from homepage" Also added unit tests to verify: - None URL is handled gracefully without crashing - Normal flow works when URL is valid Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jackwener
added a commit
that referenced
this pull request
Mar 20, 2026
Twitter migrated SearchTimeline from GET to POST; update fetch_search to route through _graphql_post via a new use_post flag on _fetch_timeline, avoiding duplicating the pagination logic (closes #39, refs #40, #42). Also guard against get_ondemand_file_url returning None so the error message is clear instead of crashing on NoneType.split (closes #43-adjacent). Refresh all FALLBACK_QUERY_IDS from live JS bundles — 18 operations updated.
Owner
|
Thanks @stoneidolon for identifying the None URL issue and adding tests! The guard is now in place in 199a149 — I used Really appreciate you also writing unit tests for this — it influenced how I validated the fix! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When get_ondemand_file_url() fails to extract the ondemand file URL from the homepage (due to page structure changes or access restrictions), it returns None. Previously, this None was passed directly to the HTTP request, causing a confusing 'NoneType' object has no attribute 'split' error.
Now we explicitly check for None and raise a clear error message: "Failed to extract ondemand file URL from homepage"
Also added unit tests to verify: