Skip to content

try mounting without fusermount(1) first#59

Merged
stapelberg merged 2 commits into
jacobsa:masterfrom
stapelberg:mount
Sep 23, 2019
Merged

try mounting without fusermount(1) first#59
stapelberg merged 2 commits into
jacobsa:masterfrom
stapelberg:mount

Conversation

@stapelberg
Copy link
Copy Markdown
Collaborator

@stapelberg stapelberg commented Dec 26, 2018

This requires root privileges or the CAP_SYS_ADMIN capability, but allows supporting -o suid.

I also addressed a bunch of readability-related nits while touching the code.

stapelberg added a commit to distr1/distri that referenced this pull request Dec 26, 2018
@stapelberg
plumb through suid bit handling
d3a069e 
Note that this depends on jacobsa/fuse#58 and
jacobsa/fuse#59, which have been temporarily vendored in
the previous three commits.
hugelgupf
hugelgupf reviewed Jul 28, 2019
View reviewed changes
Comment thread mount_linux.go
stapelberg and others added 2 commits September 19, 2019 08:50
@stapelberg
try mounting without fusermount(1) first
b71377f 
This requires root privileges or the CAP_SYS_ADMIN capability, but allows
supporting -o suid.
@stapelberg
open /dev/fuse in blocking mode so the runtime does not use a poller
53aac50 
/dev/fuse is not pollable. Go ≥ 1.13 starts reporting this on Read().
@stapelberg stapelberg merged commit 081e9f4 into jacobsa:master Sep 23, 2019
@stapelberg stapelberg deleted the mount branch September 23, 2019 15:54
@kungf
Copy link
Copy Markdown
Contributor

kungf commented Mar 9, 2020

hi, @stapelberg can you help me,with this patch when i mount fuse with root, hit the err
"mount: invalid argument"
seems mount source not work, can you give some advise?

but normal user is ok!

@stapelberg
Copy link
Copy Markdown
Collaborator Author

stapelberg commented Mar 9, 2020

Can you open an issue for that please? In the issue, can you supply an strace log (use strace -fvy -s2048 -o /tmp/strace.log in front of your command), and can you let us know how to reproduce the problem?

@kungf
Copy link
Copy Markdown
Contributor

kungf commented Mar 9, 2020

@stapelberg

Can you open an issue for that please? In the issue, can you supply an strace log (use strace -fvy -s2048 -o /tmp/strace.log in front of your command), and can you let us know how to reproduce the problem?

#76

thank you very much!

@kungf
Copy link
Copy Markdown
Contributor

kungf commented Mar 9, 2020

@stapelberg hi， can you tell something about why root not use fusermount？

@stapelberg
Copy link
Copy Markdown
Collaborator Author

stapelberg commented Mar 9, 2020

This is a requirement for supporting the -o suid option. Also, it helps in early-boot environments where fusermount might not be available.

@kungf
Copy link
Copy Markdown
Contributor

kungf commented Mar 9, 2020

This is a requirement for supporting the -o suid option. Also, it helps in early-boot environments where fusermount might not be available.

got it, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hugelgupf hugelgupf hugelgupf left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stapelberg @kungf @hugelgupf