Merged
Conversation
added 12 commits
September 15, 2022 14:21
Stanton
reviewed
Sep 20, 2022
Member
Stanton
left a comment
There was a problem hiding this comment.
minor typos, only flagged the first instances as I think there's some compiled files here in dist/
Stanton
approved these changes
Sep 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes a number of bug fixes and improvements related to the use of ARIA. How ARIA is handled and used has changed somewhat.
Separation of ARIA from base.js
Previously, much of the aria was handled in
base.jswhich set ARIA on the "selection" (span.select2-selection), this was then inherited by both single and multiple selects, which caused a number of aria issues. Now aria specific to single selects has been moved toselection/single.jsand aria specific to multiple selects moved to the inline searchselection/search.js. In multi selects, the inline search has become the combobox and not the wrapping selection span.ARIA structural changes
Single selects
aria-haspopupremoved due to lack of SR supportaria-labeladded to dropdown listboxularia-selectedtrue/falseadded. Previously only the selected item hadaria-selected="true", now the unselected options havearia-selected="false"to match the aria pattern.aria-labeladded to the dropdown search inputMulti selects
span.select2-selectionand added to the inline searchrolehas been changed fromtextboxtocomboboxon the inline search inputaria-labeladded to the dropdownullistboxaria-selectedtrue/falseadded. Previously only the selected item hadaria-selected="true", now the unselected options havearia-selected="false"to match the aria pattern.aria-controlsadded to the inline searchThis has improved screen reader coverage (see updated tables) and removed the following accessibility tool errors:
IBM Equal Access Accessibility Checker:
ulwithrole="listbox"is missing an accessible nameSite Improve:
ulis not labelledAXE:
ulis not labelledResolves #9, resolves #7