-
Notifications
You must be signed in to change notification settings - Fork 595
chore: upgrade root dependencies and fix eslint peer conflict #2771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Abhay <abhayakg123@gmail.com.com>
We should avoid the |
|
Tested again and working fine. |
|
what was the process for this upgrade? |
I used npx npm-check-updates -u at the root level to upgrade outdated dependencies listed in the main package.json. This helped clean up deprecated or vulnerable packages, improve compatibility, and align with modern tooling standards. After updating, we removed node_modules and package-lock.json, then ran a fresh npm install to ensure consistency. All builds and dev scripts were tested to confirm nothing broke post-upgrade. |
|
We don't do upgrades in this manner. It introduces too many changes at once. |
|
Most of the changes are to a patch number, not very important. We have renovate bit that performs these upgrades individually. |
Got it, thanks for the feedback! Just to clarify, the upgrades here were mostly minor and didn’t require any actual code changes, these were mainly outdated dependencies that had simple version bumps. That said, I understand your point about not introducing too many changes at once. We can definitely keep this PR open for now and revisit it later if needed. In the meantime, I’d like to shift focus to more structured upgrades starting with React itself. I think upgrading React first will help us uncover any actual compatibility issues, and once that’s in place, we can more confidently address the surrounding packages in smaller batches. Let me know if that sounds like a good approach! |
|
The upgrade here broke some unit tests. A useful change is to find out why (patch versions are unlikely to break tests). |
Signed-off-by: Abhay <abhayakg123@gmail.com.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2771 +/- ##
=======================================
Coverage 96.84% 96.84%
=======================================
Files 256 256
Lines 7951 7951
Branches 2005 2080 +75
=======================================
Hits 7700 7700
+ Misses 251 250 -1
- Partials 0 1 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
We do not chase after patch upgrades of all dependencies, if we did I'd be merging renovatebot PRs every day. If you are trying to upgrade a major or minor version, then limit the PR to just that one dependency. |
|
Yeah, that completely makes sense, we can close this PR for now. Meanwhile, I noticed that ESLint has a major update (v9), and there's already an open issue for upgrading it. I'd be happy to work on that in a new PR. I've looked into it a bit already, and there are a few breaking changes -> for example, eslint-config-airbnb doesn't support v9, and we'd need to find an alternative or adjust the config. Also, v9 uses the new flat config format instead of .eslintrc, so that'll require some migration. Let me know if you'd like me to take that on! |
go for it, but aim for small, targeted PRs |
Sure things, review noted! 🫡 |

Chore: Upgrade Root-Level Dev Dependencies #2764
This PR upgrades several development dependencies in the root
package.jsonto their latest stable versions to ensure improved stability and compatibility with modern tooling.Updated Packages
@babel/eslint-parser@typescript-eslint/eslint-plugin@typescript-eslint/parsereslinteslint-config-prettiereslint-plugin-jsx-a11yeslint-plugin-reacthuskyjsdomprettiertypescriptESLint Version Note
eslintwas updated only to^8.57.1(not upgraded to v9) due to compatibility issues witheslint-config-airbnb@19.0.4, which requireseslint@^7.32.0 || ^8.2.0.eslint@9.xcauses peer dependency resolution errors.Flat Config Migration
ESLint 9 uses the new flat config format via
eslint.config.ts, replacing older.eslintrcstyles.Currently, we are still using the legacy format. Migration to flat config will be handled in a separate PR.
Notes
Follow-up Tasks
eslint.config.ts)eslint-config-airbnbfor ESLint v9 compatibility