Migrate pkg/netutils to internal/netutils#6909
Closed
danish9039 wants to merge 3 commits intojaegertracing:mainfrom
Closed
Migrate pkg/netutils to internal/netutils#6909danish9039 wants to merge 3 commits intojaegertracing:mainfrom
danish9039 wants to merge 3 commits intojaegertracing:mainfrom
Conversation
This change is part of our ongoing effort to move public packages that are not intended for external use into the /internal directory. This prevents accidental external dependencies on our implementation details. - Moved all files from /pkg/netutils to /internal/netutils - Updated all import paths throughout the codebase - No functional changes Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6909 +/- ##
=======================================
Coverage 96.13% 96.13%
=======================================
Files 339 339
Lines 19597 19597
=======================================
Hits 18840 18840
Misses 572 572
Partials 185 185
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yurishkuro
added
the
changelog:refactoring
yurishkuro
reviewed
Mar 22, 2025
Member
yurishkuro
left a comment
yurishkuro
left a comment
There was a problem hiding this comment.
The only functionality in this package is port-related. We have a root package ports/ with some util methods, please move the functions there (assuming they are all even needed)
Signed-off-by: hippie-danish <133037056+danish9039@users.noreply.github.com>
Member
Author
ok , i will move these functions |
Member
|
already addressed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
pkg/netutilstointernal/netutilsHow was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test