Cache not refreshed.

[lz1998]

I use cached to check whether a key exist in the past 2 seconds, and I write an unit test, but it doesn't works.

#[cfg(test)]
mod tests {
    use std::thread::sleep;

    use cached::Cached;

    #[test]
    fn a() {
        let mut c = cached::TimedCache::with_lifespan_and_refresh(2, true);
        for i in 1..5 {
            let key = i.to_string().repeat(9999999);
            let value = true;
            c.cache_set(key, value);
            sleep(std::time::Duration::from_secs(1));
            // println!("{:?}", c.get_store());
        }
        assert!(c.cache_set(1.to_string().repeat(9999999), true).is_none());
    }
}

[jaemk]

Yes, there does appear to be a bug. cache_set and cache_remove should be checking the timestamp of the existing value before returning. It looks like the TimedSized store has the same bug too. I'll put a fix in this evening.

cached/src/stores/timed.rs

Lines 177 to 183 in 3a8d0e0

	fn cache_set(&mut self, key: K, val: V) -> Option<V> {
	let stamped = (Instant::now(), val);
	self.store.insert(key, stamped).map(|(_, v)| v)
	}
	fn cache_remove(&mut self, k: &K) -> Option<V> {
	self.store.remove(k).map(|(_, v)| v)
	}

cached/src/stores/timed_sized.rs

Lines 167 to 175 in 3a8d0e0

	fn cache_set(&mut self, key: K, val: V) -> Option<V> {
	let stamped = self.store.cache_set(key, (Instant::now(), val));
	stamped.map(|stamped| stamped.1)
	}
	fn cache_remove(&mut self, k: &K) -> Option<V> {
	let stamped = self.store.cache_remove(k);
	stamped.map(|stamped| stamped.1)
	}

[lz1998]

In my application, the key will be a large string, so I hope to clear them as soon as possible to save memory.

[jaemk]

The insert/remove bug is fixed by this commit d5ac5fe and a new flush method was added to the timed and timed-sized caches in this commit 26ef57a . cache_get will delete expired items when you try to access them, but if you want the cache to be constantly flushed, then you'll need to start your own background thread or task to call .flush() every couple seconds.

This was released in 0.30.0

[lz1998]

The insert/remove bug is fixed by this commit d5ac5fe and a new flush method was added to the timed and timed-sized caches in this commit 26ef57a . cache_get will delete expired items when you try to access them, but if you want the cache to be constantly flushed, then you'll need to start your own background thread or task to call .flush() every couple seconds.

This was released in 0.30.0

I have tried the latest version, and I found that metrics will not change when accessing items with cache_set.