Skip to content

Add Elixir 1.19/OTP 28 to CI matrix and bump actions#39

Merged
jaeyson merged 1 commit intojaeyson:mainfrom
myfloss:support-elixir-119-in-ci
Mar 8, 2026
Merged

Add Elixir 1.19/OTP 28 to CI matrix and bump actions#39
jaeyson merged 1 commit intojaeyson:mainfrom
myfloss:support-elixir-119-in-ci

Conversation

@kianmeng
Copy link
Copy Markdown
Contributor

@kianmeng kianmeng commented Mar 4, 2026

Summary by Sourcery

Expand CI coverage to Elixir 1.19 with OTP 28 across supported Typesense versions and update GitHub Actions used in CI workflows.

CI:

  • Add Elixir 1.19 and OTP 28 job variants to the CI matrices for Typesense 26.0, 27.0, 27.1, and 28.0.
  • Upgrade checkout and cache GitHub Actions to their latest major versions in all CI workflows.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Mar 4, 2026

Reviewer's Guide

Updates the GitHub Actions CI workflows to add Elixir 1.19 / OTP 28 combinations to the matrix for Typesense 26.x–28.x workflows and bumps GitHub Actions for checkout and caching to their latest major versions.

File-Level Changes

Change Details Files
Extend CI matrices to test Elixir 1.19 with OTP 28 across supported Typesense versions.
  • Add a new matrix entry for Typesense 28.0 using OTP 28 and Elixir 1.19 with lint enabled in the v28.0 workflow.
  • Add new matrix entries for Typesense 26.0, 27.0, and 27.1 workflows using OTP 28 and Elixir 1.19 with lint disabled to keep behavior consistent with existing non-lint entries.
.github/workflows/ci_v26.0.yml
.github/workflows/ci_v27.0.yml
.github/workflows/ci_v27.1.yml
.github/workflows/ci_v28.0.yml
Upgrade GitHub Actions dependencies for checkout and caching to newer major versions.
  • Bump actions/checkout from v4 to v6 in all CI workflows.
  • Bump actions/cache from v4 to v5 for general dependency caching.
  • Bump actions/cache/restore and actions/cache/save from v4 to v5 for PLT cache management in the v28.0 workflow.
.github/workflows/ci_v26.0.yml
.github/workflows/ci_v27.0.yml
.github/workflows/ci_v27.1.yml
.github/workflows/ci_v28.0.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 2 issues, and left some high level feedback:

  • In ci_v28.0.yml the new Elixir 1.19/OTP 28 entry is now the only one with lint: true and the previous 1.18 combo was changed to lint: false; double-check that this change in which matrix variant runs linting is intentional.
  • The Elixir/OTP matrix and GitHub Actions versions are repeated across ci_v26.0.yml, ci_v27.0.yml, ci_v27.1.yml, and ci_v28.0.yml; consider extracting a reusable workflow or shared matrix definition to avoid duplication when adding or updating versions in the future.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In `ci_v28.0.yml` the new Elixir 1.19/OTP 28 entry is now the only one with `lint: true` and the previous 1.18 combo was changed to `lint: false`; double-check that this change in which matrix variant runs linting is intentional.
- The Elixir/OTP matrix and GitHub Actions versions are repeated across `ci_v26.0.yml`, `ci_v27.0.yml`, `ci_v27.1.yml`, and `ci_v28.0.yml`; consider extracting a reusable workflow or shared matrix definition to avoid duplication when adding or updating versions in the future.

## Individual Comments

### Comment 1
<location path=".github/workflows/ci_v28.0.yml" line_range="51" />
<code_context>
     steps:
       - name: Checkout repo
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6

       - name: Check for misspellings
</code_context>
<issue_to_address>
**issue (bug_risk):** Using `actions/checkout@v6` is likely invalid and will cause workflow failures.

GitHub Actions currently exposes `actions/checkout` only up to v4, so this reference will fail to resolve and the job will never start. Please pin to `actions/checkout@v4` (or another existing major or commit) and apply the same fix to all affected workflows.
</issue_to_address>

### Comment 2
<location path=".github/workflows/ci_v28.0.yml" line_range="98" />
<code_context>

       - name: Cache dependencies/builds
-        uses: actions/cache@v4
+        uses: actions/cache@v5
         with:
           path: |
</code_context>
<issue_to_address>
**issue (bug_risk):** Upgrading to `actions/cache@v5` may be invalid and break dependency caching.

`actions/cache` is currently stable at `v4`. Referencing `@v5` when that major version doesn’t exist will cause the action resolution to fail and disable all caching (including the later PLT cache steps). Please keep this on `@v4` or another known existing version until `v5` is actually released and verified.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread .github/workflows/ci_v28.0.yml
Comment thread .github/workflows/ci_v28.0.yml
Copy link
Copy Markdown

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No application code in the PR — skipped Code Health checks.

See analysis details in CodeScene

Quality Gate Profile: The Bare Minimum
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

@jaeyson jaeyson merged commit a6c2912 into jaeyson:main Mar 8, 2026
16 checks passed
@kianmeng
Copy link
Copy Markdown
Contributor Author

kianmeng commented Mar 9, 2026

🥳 🥳 🥳 🥳 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants