Add Elixir 1.19/OTP 28 to CI matrix and bump actions#39
Merged
jaeyson merged 1 commit intojaeyson:mainfrom Mar 8, 2026
Merged
Conversation
Reviewer's GuideUpdates the GitHub Actions CI workflows to add Elixir 1.19 / OTP 28 combinations to the matrix for Typesense 26.x–28.x workflows and bumps GitHub Actions for checkout and caching to their latest major versions. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 2 issues, and left some high level feedback:
- In
ci_v28.0.ymlthe new Elixir 1.19/OTP 28 entry is now the only one withlint: trueand the previous 1.18 combo was changed tolint: false; double-check that this change in which matrix variant runs linting is intentional. - The Elixir/OTP matrix and GitHub Actions versions are repeated across
ci_v26.0.yml,ci_v27.0.yml,ci_v27.1.yml, andci_v28.0.yml; consider extracting a reusable workflow or shared matrix definition to avoid duplication when adding or updating versions in the future.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `ci_v28.0.yml` the new Elixir 1.19/OTP 28 entry is now the only one with `lint: true` and the previous 1.18 combo was changed to `lint: false`; double-check that this change in which matrix variant runs linting is intentional.
- The Elixir/OTP matrix and GitHub Actions versions are repeated across `ci_v26.0.yml`, `ci_v27.0.yml`, `ci_v27.1.yml`, and `ci_v28.0.yml`; consider extracting a reusable workflow or shared matrix definition to avoid duplication when adding or updating versions in the future.
## Individual Comments
### Comment 1
<location path=".github/workflows/ci_v28.0.yml" line_range="51" />
<code_context>
steps:
- name: Checkout repo
- uses: actions/checkout@v4
+ uses: actions/checkout@v6
- name: Check for misspellings
</code_context>
<issue_to_address>
**issue (bug_risk):** Using `actions/checkout@v6` is likely invalid and will cause workflow failures.
GitHub Actions currently exposes `actions/checkout` only up to v4, so this reference will fail to resolve and the job will never start. Please pin to `actions/checkout@v4` (or another existing major or commit) and apply the same fix to all affected workflows.
</issue_to_address>
### Comment 2
<location path=".github/workflows/ci_v28.0.yml" line_range="98" />
<code_context>
- name: Cache dependencies/builds
- uses: actions/cache@v4
+ uses: actions/cache@v5
with:
path: |
</code_context>
<issue_to_address>
**issue (bug_risk):** Upgrading to `actions/cache@v5` may be invalid and break dependency caching.
`actions/cache` is currently stable at `v4`. Referencing `@v5` when that major version doesn’t exist will cause the action resolution to fail and disable all caching (including the later PLT cache steps). Please keep this on `@v4` or another known existing version until `v5` is actually released and verified.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
No application code in the PR — skipped Code Health checks.
See analysis details in CodeScene
Quality Gate Profile: The Bare Minimum
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
jaeyson
approved these changes
Mar 8, 2026
Contributor
Author
|
🥳 🥳 🥳 🥳 🥳 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Expand CI coverage to Elixir 1.19 with OTP 28 across supported Typesense versions and update GitHub Actions used in CI workflows.
CI: