fix: quote dogfooding label color to prevent YAML sci-notation parse#98
Merged
fix: quote dogfooding label color to prevent YAML sci-notation parse#98
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
=======================================
Coverage 76.18% 76.18%
=======================================
Files 70 70
Lines 6875 6875
Branches 898 897 -1
=======================================
Hits 5238 5238
Misses 1619 1619
Partials 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
label-syncCI job was failing with:The
dogfoodinglabel (index 10) has color5319E7. YAML 1.1 parsers interpret this as scientific notation (5319 × 10^7), producing a number instead of a string.Fix
Wrap the hex color value in double quotes so YAML always parses it as a string: