Skip to content

Use create zones utility in the foundation version#288

Closed
muezabdalla wants to merge 6 commits into
jaheyns:masterfrom
muezabdalla:use_createZones
Closed

Use create zones utility in the foundation version#288
muezabdalla wants to merge 6 commits into
jaheyns:masterfrom
muezabdalla:use_createZones

Conversation

@muezabdalla
Copy link
Copy Markdown
Contributor

the foundation version made the createZones utility as a replacement for topoSet and it is alot easier to use.
and the topoSet is now marked as depricated in the foundation version.

@muezabdalla muezabdalla marked this pull request as draft May 21, 2026 21:51
@muezabdalla muezabdalla marked this pull request as ready for review May 21, 2026 22:47
Comment thread Data/Templates/case/Allrun.ps1 Outdated
%:True
# Set cell zones contained inside the .stl surfaces
runCommand topoSet -dict system/topoSetZonesDict
if( (Get-Command createNonConformalCouples) )
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

createNonConformalCouples -> createZones?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was a mistake. now fixed it

runCommand createPatch -overwrite

# Set cell zones contained inside the .stl surfaces
if( (Get-Command createNonConformalCouples) )
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you update this to account for the fix?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now fixed it

@oliveroxtoby
Copy link
Copy Markdown
Collaborator

Could you check that all tests are passing and update reference data where appropriate? I am seeing a few discrepancies.

@muezabdalla
Copy link
Copy Markdown
Contributor Author

I get 1 error and 1 failure but those are related to other demos and I am working on there fixes.
but the meanvelocity and the Periodic demos runs fine.

@muezabdalla
Copy link
Copy Markdown
Contributor Author

sorry now I found that I did the tests with the master branch. and when I did it with the feature branch it gave me alot of errors.
I will investigate the problem.

@muezabdalla
Copy link
Copy Markdown
Contributor Author

looks like it was a problem in conflicting commits or something like that.
I remade this PR here:#295. so I will close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants