Skip to content

testNotLikeConstraintCustomWildcardsAndEscape has erroneous quote character in pattern#1369

Merged
otaviojava merged 1 commit intojakartaee:mainfrom
njr-11:1364-extra-quote-in-pattern-for-testNotLikeConstraintCustomWildcardsAndEscape
Feb 11, 2026
Merged

testNotLikeConstraintCustomWildcardsAndEscape has erroneous quote character in pattern#1369
otaviojava merged 1 commit intojakartaee:mainfrom
njr-11:1364-extra-quote-in-pattern-for-testNotLikeConstraintCustomWildcardsAndEscape

Conversation

@njr-11
Copy link
Copy Markdown
Member

@njr-11 njr-11 commented Feb 10, 2026

This PR fixes a bug found by @dstepanov in #1364 (comment)

The pattern erroneously includes a " character at the end,

%_aa%"

It is querying data that consists of country names, and no country name ends with or even has a " character in it, so the NotLike constraint would end up matching every country name in the database instead of the limited set that corresponds to the rest of the pattern, causing the assert to fail.

As would be expected, this only runs successfully for me without the erroneous " character at the end of the pattern. My guess is that \" was inserted by my code editor when I copy and pasted code with the pattern in it and mistakenly ended up in the test that way.

@njr-11 njr-11 added this to the 1.1 milestone Feb 10, 2026
@njr-11 njr-11 added bug Something isn't working test Something test-related labels Feb 10, 2026
@njr-11 njr-11 mentioned this pull request Feb 10, 2026
@otaviojava otaviojava merged commit 93de532 into jakartaee:main Feb 11, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working test Something test-related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants