some misc code simplifications in Records#1380
Merged
otaviojava merged 1 commit intojakartaee:mainfrom Feb 20, 2026
Merged
Conversation
63cf098 to
7f4fede
Compare
otaviojava
approved these changes
Feb 18, 2026
njr-11
reviewed
Feb 18, 2026
Member
njr-11
left a comment
There was a problem hiding this comment.
The changes look correct, but a general comment is that although the use of String addition does make the code more concise, repeated String concatenation is also less efficient than StringBuilder.
Member
Author
I don't think that's been true for a long time. String concatenation used to desugar to (It still makes sense to use |
njr-11
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.