Disallow literals with null type()#1383
Merged
otaviojava merged 2 commits intojakartaee:mainfrom Feb 24, 2026
Merged
Conversation
gavinking
reviewed
Feb 24, 2026
gavinking
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a few of these corrections mixed in under the BooleanExpression/Attribute PR, but that won't necessarily go in, so I have split out the unrelated parts to this PR.
This includes null checking for Literal subtypes that could otherwise be invalidly constructed with a null
type().Also, it adds in a missing
@Overridethat was causing the project not to build locally.It also removes a
.ofmethod from LiteralRecord, which is not the correct place for it.