Skip to content

clarify that user-defined generic repository supertypes are not supported#575

Merged
otaviojava merged 1 commit intojakartaee:mainfrom
gavinking:generics
Mar 22, 2024
Merged

clarify that user-defined generic repository supertypes are not supported#575
otaviojava merged 1 commit intojakartaee:mainfrom
gavinking:generics

Conversation

@gavinking
Copy link
Member

At least not in Jakarta Data 1.0.

@gavinking
Copy link
Member Author

Well, OK, so I found the method Types.asMemberOf(), which let me implement support for user-written generic repository supertypes, I believe robustly, using the compiler's own logic for type argument substitution. So for any implementation based on annotation processors, the requirement which is relaxed by this pull request is actually not anywhere near as much of a difficultly as I feared.

However, we don't require the use of annotation processing by implementors of Jakarta Data, and so I guess there's still a concern for implementations not based on annotation processing.

Anyway, I'll let ya'll decide what to do with this. I guess I'm OK with making or not making the change.

@otaviojava otaviojava merged commit 8087e42 into jakartaee:main Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants