Allow NoSQL to defer request for totals and raise UnsupportedOperationException later#967
Merged
otaviojava merged 2 commits intojakartaee:mainfrom Feb 13, 2025
Conversation
…nException later Signed-off-by: Nathan Rauh <nathan.rauh@us.ibm.com>
gavinking
reviewed
Feb 12, 2025
Member
This is a good solution to the problem. 👍 |
Co-authored-by: Gavin King <gavin@hibernate.org>
gavinking
approved these changes
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accommodate NoSQL databases that are incapable of page totals by clarifying that the request for totals can be deferred until they are asked for, and prepare the user for the possibility of an exception to be raised at that time rather than immediately upon supplying the PageRequest with requestTotals to a repository method.
This goes along with Otavio's #963 where we are trying to figure out a compatible way for NoSQL databases that aren't capable of retrieving totals to be usable for PageRequest instances that by default do not set withoutTotals.