Implement the OutputPath variable #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements the OutputPath variable that was previously defined. Allows the op to specify a path to store the Locksmith CSV files in. (Defaults to the current working directory.) Also prefixes the CSVs with "Locksmith" and the current timestamp.
jakehildreth
reviewed
Sep 1, 2024
jakehildreth
reviewed
Sep 1, 2024
jakehildreth
requested changes
Sep 1, 2024
Owner
jakehildreth
left a comment
jakehildreth
left a comment
There was a problem hiding this comment.
Almost there. Need to improve PS5.1 support and clean up the filename prefix.
Removed extra space in file name prefix. Removed errormessage in validate script for backwards compatibility.
Collaborator
Author
|
Changes made. Ready for review again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the OutputPath variable that was previously defined. Allows the op to specify a path to store the Locksmith CSV files in. (Defaults to the current working directory.) Also prefixes the CSVs with "Locksmith" and the current timestamp.