Add ESC7 Checks #246
Merged
Add ESC7 Checks #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2025.04.20 Release
…ibutes, but it's working!
SamErde
reviewed
May 19, 2025
SamErde
reviewed
May 19, 2025
SamErde
requested changes
May 19, 2025
Collaborator
SamErde
left a comment
SamErde
left a comment
There was a problem hiding this comment.
Haven't had a chance to fully test yet, but LGTM! Just has 2 typos "pinicipal" and an optional suggestion for readable output.
Owner
Author
|
@SamErde Readability changes in place, and 2 typos fixed. I found a couple more copy/paste errors on my own. If g2g, please merge! |
SamErde
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic ESC7 Checks are operational (#226).
Still needs: