change autoToString to apply to the class instead of the method#3
Merged
change autoToString to apply to the class instead of the method#3
Conversation
Owner
Author
|
Fwiw @scheglov I wanted to try migrating json_serializable to this style as well, to see if it makes it faster. It should, because we could share more introspection requests (related to fields) across toJson/fromJson, as well as eliminating duplicate diagnostics that we show sometimes right now. |
|
Yes, I was able to reproduce the issue, and will fix it. |
copybara-service Bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Apr 10, 2024
jakemac53/macros_example#3 Change-Id: I65b5c515e78223c14371748f644905f57198b73e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/362184 Reviewed-by: Jake Macdonald <jakemac@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Owner
Author
|
Can confirm that fixed it, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @scheglov this causes the analyzer to fail when analyzing
bin/auto_to_string.dart.I wasn't able to get anything interesting out of the logs - and it doesn't crash the entire analyzer - but it does break analysis for this specific library.