Replace shortid to nanoid #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you for providing a replacement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. Thanks for an awesome project. I found the way how to make it a little better. By replacing unique ID generator from
shortidtonanoid.shortidis not maintained anymore (and issue tracker has many important issues). I tried to took maintenance, but found that I can’t fixshortidwith keeping API.nanoidis just 179 bytes.shortidis 2 times bigger (about 0.5 KB).nanoidis 10x times faster thanshortid.@jakezatecky I kept old ID size, everything will be the same for the user. I also run
npm run example(not sure that I should update examples too).