Skip to content

FIX: Issue-61. Don't change disable children on parent click #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2018
Merged

FIX: Issue-61. Don't change disable children on parent click #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/js/CheckboxTree.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ class CheckboxTree extends React.Component {

toggleChecked(node, isChecked, noCascade) {
if (node.children === null || noCascade) {
if (node.disabled) return;
Copy link
Owner

@jakezatecky jakezatecky Nov 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer this check to go down to where the children loop is, because the originator of the check (the parent) had to be enabled, so this check is slightly redundant for the root request.

I am also not a fan of shorthand if statements, so I would prefer the longer version with curly braces (actually surprised this is not enabled as an ESLint rule...I'll have to look into that).

// Set the check status of a leaf node or an uncoupled parent
this.toggleNode('checked', node, isChecked);
} else {
Expand Down