FIX: Issue-61. Don't change disable children on parent click #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajkagy
approved these changes
Nov 16, 2017
Owner
|
EDIT: nevermind. I misunderstood the original intent. |
jakezatecky
requested changes
Nov 21, 2017
Owner
jakezatecky
left a comment
jakezatecky
left a comment
There was a problem hiding this comment.
Thanks for the PR. If you could make that modification, I'll merge it in.
|
|
||
| toggleChecked(node, isChecked, noCascade) { | ||
| if (node.children === null || noCascade) { | ||
| if (node.disabled) return; |
Owner
There was a problem hiding this comment.
Would prefer this check to go down to where the children loop is, because the originator of the check (the parent) had to be enabled, so this check is slightly redundant for the root request.
I am also not a fan of shorthand if statements, so I would prefer the longer version with curly braces (actually surprised this is not enabled as an ESLint rule...I'll have to look into that).
jakezatecky
added a commit
that referenced
this pull request
Sep 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#61