refactorisation du code + ajout de type aux vairables#1
Open
Mideky-hub wants to merge 2 commits into
Open
Conversation
added lambda iteration and reduce the scope iteration Signed-off-by: Mathieu KERBEL <mathieukerbel@gmail.com>
Author
|
d'ailleurs ça serait cool, je t'ai laissé 2 vulnérabilités dans le code, j'aimerais bien que tu les trouves, des trucs qui ferais crasher le code si jamais tel ou tel scénar arrive :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
j'ai ajouté des types à tes variables et j'ai condensé tes loop pour qu'elles se plient à ta données et pas l'inverse.
C'est un avis un peu perso mais je trouve plus facile à lire du code quand la boucle se trouve directement à niveau de réception : "total" ici par exemple, on comprends que c'est une boucle ensuite qui va looper dans les différentes montant de chaque pays/clients pour sommer les résultats et les stocker dans le total du dico par pays.
Même si la boucle ensuite est rédigé verbeusement, tu comprends ce qu'elle en ressort