Package causes constant reloads

[StorytellerCZ]

Recently tested out a branch in my project and the package causes constant reloads:

Screencast.from.2024-10-04.08-23-15.mp4

Removing the package ends the reloads. Clearing IndexedDB does fix the issue as well.

I'm wondering if this is due to some issue between versions or specific to HMR in development.

Either way wanted to let you know and everyone else how to fix this.

[jamauro]

Thanks for reporting. I will try to repro. If you can isolate with some specific repro steps, that would really help diagnose. It's entirely possible that this only happens with HMR.

I suggest starting from a clean slate to see if you can repro reliably.

[jamauro]

I was able to repro this when flipping between the tests for the package and running my app. There was some stale data in the syncs indexeddb object store. This should be fixed in v0.3.1.

[StorytellerCZ]

Thanks a lot!

[wildhart]

I'm still getting infinite reloads with v0.3.1. I'm upgrading from v0.2.3 on my project. Running with 0.2.3 is fine, then meteor add jam:offline@0.3.1 and re-start causes an infinite reload.

Downgrading to 0.2.3 or clearing all site data fixes the reload.

[StorytellerCZ]

Can confirm this again. I have added MontiAPM and after HMR the page started re-loading non-stop. Also got reports from some customers with the same problem.

[jamauro]

Thanks for reporting. If y'all could help with a minimal repro, I'd really appreciate it.

One other thing that could help diagnose: use the package locally in your packages folder, console log the keepErrors and comment out the window.reload inside here:

offline/lib/config.js

Line 23 in 9cb6c4c

handleSyncErrors: ({ replayErrors, keepErrors }) => {

and share the errors you see.

[StorytellerCZ]

Will try to use locally when I get on a train later today.

[StorytellerCZ]

Got this:

The condition to trigger this was that the user had to be logged in.

[jamauro]

Thanks. Still not entirely sure what the root cause is. I was hoping that console logging keepErrors might provide some clues. But I will add some better error handling for the clear function.

[StorytellerCZ]

I think I found the issue. PR incoming.

[jamauro]

I just published v0.3.2 that improves error handling and removes automatic reloading of the window. Curious to hear how it goes for y'all and if you continue seeing errors in the browser console when syncing. Please share if you do so we can rule out any issues with this package and possibly reintroduce automatic reload if it makes sense.