Issue with soft-delete package

[harry-73]

Hi,

I have a .once publication, I subscribe to it and I have a method which call removeAsync.
So the document is soft deleted on server side but not changed message is sent to the client.

looking at the mongo.js code, in the updateAsync (at the end updateAsync is called as it is soft delete so we update the deleted field to true ) part :

 const finalFilter = hasId ? filter : insertedId ? { _id: insertedId } : docIds ? {_id: numberAffected === 1 ? docIds[0] : { $in: docIds }} : undefined;
 const { projection, unsets = [] } = finalFilter && createProjection(modifier);
const items = finalFilter ? await this.find(finalFilter, { projection }).fetchAsync() : [];

with finalFilter = { _id: ObjectID { _str: '6a1a43125abc95913356c0c7' }
and projection = { deleted: 1, deletedAt: 1, updatedAt: 1 }

items, at the end, is equal to [] so no changed message sent

If I modify for testing pupose finalFilter to { _id: ObjectID { _str: '6a1a43125abc95913356c0c7', deleted: true }
items is not empty ans the changed message is correctly sent

[StorytellerCZ]

That looks like correct behavior with .once.
From my understanding the .once acts like a method that returns documents. The difference with a method is that it puts those documents into minimongo. Once that is done, that is it. There is no subscription or anything, so once the document is removed on the server there is nothing for it to indicate that it should notify the client. If you want that you need to have that method being triggered on client as well, so that it can simulate the result in minimongo.

[harry-73]

Hi @StorytellerCZ

No, pub-sub package rewrites insertAsync, updateAsync, ... to be able to sent messages through ddp (see mongo.js file)

if you add a document via a method that matches a .once publication a added message will be sent from the server to the client.

Idem when you update a document, a updated message is sent.
If you remove (with soft delete package) a document, a removed message is sent.

[jamauro]

@harry-73 Thanks for reporting. I plan to look into this soon. What does your method which originally invokes removeAsync look like?

[jamauro]

From my understanding the .once acts like a method that returns documents. The difference with a method is that it puts those documents into minimongo. Once that is done, that is it. There is no subscription or anything, so once the document is removed on the server there is nothing for it to indicate that it should notify the client.

@StorytellerCZ Not exactly. When using .once and performing write operations, reactivity for the writer will be preserved so it goes beyond merely fetching and merging into minimongo.

[harry-73]

What does your method which originally invokes removeAsync look like?

export const activitydelete = new ValidatedMethod({
  name: 'activity.delete',
  rateLimit: {
    numRequests: 5,
    timeInterval: 5000
  },
  validate: new SimpleSchema({
    activityId: { type: Mongo.Collection.ObjectID },
    'activityId._str': { type: String },
  }).validator(),

  run: async function ({ activityId }) {
    if (!this.userId)
      throw new Meteor.Error(
        'Activities.methods.activitydelete.notloggued',
        'Vous devez être loggué.'
      );

    try {    
        await Activities.removeAsync({ _id: activityId });
    } catch(error) {
        console.error('activity.delete method error:', error);
    }
  }
});

The configuration of the jam:soft-delete package:

SoftDelete.configure({
  deleted: 'deleted', // the field name used for the boolean flag. you can update to your preference, e.g. 'isDeleted'
  deletedAt: 'deletedAt', // add the name of the field you'd like to use for a deletedAt timestamp, e.g. 'deletedAt', if you want to include it on your docs
  autoFilter: true, // automatically adds the { [deleted]: false } filter to your queries
  overrideRemove: true // overrides the Collection.removeAsync method to make it a soft delete instead
});

[harry-73]

Hi @jamauro

Did you have time to look at it ?

Thanks