Introducing boolean combinators without deps. #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As mentioned in woylie#596, the goal is to attempt to do this without introducing additional dependencies. I thought of 3 ways to do this, and I wasn't entirely sure which one to go with, so initially I tried them all.
Ecto.Typeand just cast this inside the main changesets. However, I ran into an issue with a circular dependency betweenFlop.Combinatorrequiring this custom type, and this custom type also requiringFlop.Combinatorfor its changeset.polymorphic_embedjust focusing on our use-case, this is the one in this PR.